Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas-class Light Armored Crusier #3246

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

meemofcourse
Copy link
Contributor

@meemofcourse meemofcourse commented Jul 25, 2024

About The Pull Request

imagen
atlas2

The Atlas-class is the first Colonial League ship following the CLIP Rework. The decaling and general decoration of the ship needs a revision, but otherwise, it is intended as a small, overall generalist patrol vessel to the likes of the Vaquero. The 4-Minutemen team, lead by one Sergeant, is subordinate to the First Officer and Captain, who overlook the operation of the ship by the Corpsman and the Engineer.

It is staffed by:

  • 1 Captain
  • 1 First Officer
  • 1 Sergeant
  • 1 Corpsman
  • 1 Engineer
  • 4 Minutemen
  • 1 Deckhand

Why It's Good For The Game

it's the clip ship it uses the colon league content

Changelog

🆑
add: Atlas-class Light Armored Crusier
/:cl:

@meemofcourse meemofcourse requested a review from a team as a code owner July 25, 2024 02:23
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Jul 25, 2024
@kaylexis
Copy link

CLIP IS SO BACK.

@Martinpachu
Copy link
Contributor

it's peak chat

@Martinpachu
Copy link
Contributor

imagen
it has a 762 box but no guns that use 762 i think?

@Martinpachu
Copy link
Contributor

there's no gravity generator!!

@Martinpachu
Copy link
Contributor

i might be a stupid baby but i don't think the cargo bay doors are linked to any buttons. also no holofields ? also just my dumb gay opinion but there could be another candor mag

@firebudgy
Copy link
Contributor

firebudgy commented Jul 25, 2024

image
I think you forgot a couple wires for the engines here

@firebudgy
Copy link
Contributor

image
Bridge lockdown button closes all these shutters, while the bridge windows button does nothing

image
Every other ship usually has windows blocking the dorms so SSD people don't get obliterated by carps while away from their computer, so I'm just wanting point it out in case you forgot or something

image
Same with the medical bay external window shutters, I'm just pointing this out in case their omission was an accident

@Sadhorizon
Copy link
Contributor

Sadhorizon commented Jul 25, 2024

  • They don't have a single space suit on the entire ship.
    obraz
  • Why is it just... sticking out like that... surely there is a better way to handle it. Maybe a window into grilles?
    obraz
  • Most ships have shutters on the precharger. Cuz, technically, you are blocking engine output rn. (lore-wise)
  • The cargo bay has very little cargo space. I'd suggest, on the right side, making more room for a crate shelf. Also switching the air tank rack for an air tank crate, cuz it's less stationary.
    obraz
  • This locker has the wrong dir.
    obraz
  • This airlock has no controller and no vents.
    obraz
  • Empty space spotted. Could put a vendor or something here. Cigs never hurt anybody.
    obraz
  • No air pump? Also, missing cable (marked green).
    obraz
  • You forgot holofields, and also a shutter button.
  • Bridge airlocks don't have access req set.
  • Airlocks aren't named. Probably not needed, but still nice to have.
    obraz
  • You have two air cans, but no ports to put them in. Would probably be nice.
  • All of your light switches are like. Very high. Latency explained to me before, that shadow should be touching the ground. Just pointing it out.
    obraz
  • When those are next to each other, .i makes you speak on both, which is kinda annoying.
  • Medical lacks surgical tools.
  • There is no CLIP stamp on board.

@Martinpachu
Copy link
Contributor

small suggestion, maybe start with a bit of glass and iron for the autolathe?

@Martinpachu
Copy link
Contributor

imagen
the turret panel is unreachable

@Sadhorizon
Copy link
Contributor

small suggestion, maybe start with a bit of glass and iron for the autolathe?

Some plastic is neat to have too! Just a lil bit, for when you need it.

@Martinpachu
Copy link
Contributor

deleted because im stupig nevm

@meemofcourse
Copy link
Contributor Author

imagen it has a 762 box but no guns that use 762 i think?

imagen
:(

@meemofcourse
Copy link
Contributor Author

Why is it just... sticking out like that... surely there is a better way to handle it. Maybe a window into grilles?

nah

Empty space spotted. Could put a vendor or something here. Cigs never hurt anybody.

i am avoiding vendors on the argument that this is a military vessel

There is no CLIP stamp on board.

intended for admin use. you shouldn't be able to stamp things on behalf of the entire country

@Martinpachu
Copy link
Contributor

imagen
cargo bay doors opens only one door. also, idk if i just didn't see it, but there should be a cell charger somewhere. since that's standard for every ship i believe.

@Martinpachu
Copy link
Contributor

actually, weren't communications consoles off limits? since you can do stuff like request nuclear access codes and send announecements. i vaguely remember them not being allowed.

Copy link
Member

@goober3 goober3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, i'm 'Shiptest Maptainers' and i am going to review this PR.

f1f64e81897216c2086df5c143c19bd9
the cryo room could do with a light switch.

8f7580882b9d75c13bef97899ad81a54
consider removing the curtain here, i don't think it works with the cyborg recharger sprite.

9ec48364337401afc8db399a08ebea88
please make these sidings reach the bottom of the room i beg

d479ab47eda7ea6bfbefd70f70e70fc9
these railings don't look great in my opinion!!! consider making it a single rail or removing them altogether. also look into accenting the floor in the wider canteen area with some techfloor to make it a little more visually interesting.

659420d0ee230553c0f6d3bf1b090e5f
i think the cell here warps the ship shape a little too much. could you maybe move it to where the grilles are here, or somewhere else on the ship.
image

ed3e8b83d90f425fcb1fa1a2875042b8
i like this hallway. why is there a microwave here. can you put warning stripes on the firelocks and replace them with directional variants by the way.

ff6c5492a1bbd39a9dd05fca8f034920
i also really like this room. consider giving them a crate shelf (x1)

image
oh no, i guess i can't perform this life-saving surgery. what a shame.

we have CLIP guns now. use them. look into code/modules/projectiles/guns/manufacturer/clip_lanchester/ballistics.dm for an idea of what to use where. (replace the captain's pistol with a CM-70)

74f62c97f4ea57dbb6c7c5d19cf03eae
guess i'll fly into an asteroid field then.

image
why does the first officer have so much clothing

e7880e40a6e8f5b207444db7eba0afc4
consider more catwalks and rusted plating on both sides of the engine room. this seems a little too clean and orderly. also, add windoors to the engine chargers.

6ea8fe7f53523cf87cc90c18210d145c
these shutters (bottom) appear to be connected to the dorm windows rather than the FO's privacy shutters

that's about it i think

@meemofcourse
Copy link
Contributor Author

consider removing the curtain here, i don't think it works with the cyborg recharger sprite.

but lat did it in the panacea and nobody said anything :(

can you put warning stripes on the firelocks and replace them with directional variants by the way.

yes, but i'm not changing them to directionals because this is a door dividing a hallway and the thin ones work best for airlocks

oh no, i guess i can't perform this life-saving surgery. what a shame.

guess i'll fly into an asteroid field then.

cdn is fucked what do you want me to do

why does the first officer have so much clothing

formal uniforms to hand to the crew. you know, it's a military

jeorg shiptest maptainers with 30 reviews is an outlier and should not be counted
@rye-rice
Copy link
Member

I will assume by lack of maptainer review this is ready to merge

@meemofcourse
Copy link
Contributor Author

please don't until another maptainer approves it

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Sep 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@FalloutFalcon FalloutFalcon added the Ship Ship successfully tested. label Sep 20, 2024
@rye-rice
Copy link
Member

@Latentish @Apogee-dev

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Sep 22, 2024
@@ -0,0 +1,49 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "faction": "/datum/faction/clip", somewhere, or it's gonna show as indie on the spawning menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants